Fix/add bulk url #2084
Draft
Fix/add bulk url #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafeeqd959
reviewed
Aug 25, 2025
| } | ||
| const branch = config?.branch || 'main'; | ||
| const host = stack?.host || config?.host || 'app.contentstack.com'; | ||
| const appUrl = getAppUrlFromHost(host); |
There was a problem hiding this comment.
What about non branch enabled stack ? do we need to consider that ?
| @@ -0,0 +1,39 @@ | |||
| const { regions } = require('@contentstack/cli-config/lib/utils/region-handler'); | |||
There was a problem hiding this comment.
can you name this file better, since the folder tells it that is a group of utilities, give name specific to its usage for better understanding such as "generate-bulk-publish-url.js"
| @@ -1,11 +1,12 @@ | |||
| { | |||
| "name": "@contentstack/cli-cm-bulk-publish", | |||
| "description": "Contentstack CLI plugin for bulk publish actions", | |||
| "version": "1.9.0", | |||
| "version": "1.9.1", | |||
There was a problem hiding this comment.
@sunil-lakshman its a new feature not a bug fix or a patch, for feature updates we have to bump the minor version, this should reflects in the contentstack package.json as well cli will get minor update
|
@sunil-lakshman please mention the ticket number like fix/CS-123434, also please get @AniketDev7 tested this before merge it to development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.