Skip to content

Removing of option from mcp_gateways/BackendTransportService - #17

Merged
dawid-nowak merged 2 commits into
mainfrom
user/dawid.nowak/replacing_option_take_with_mutex
May 19, 2026
Merged

Removing of option from mcp_gateways/BackendTransportService#17
dawid-nowak merged 2 commits into
mainfrom
user/dawid.nowak/replacing_option_take_with_mutex

Conversation

@dawid-nowak

Copy link
Copy Markdown
Contributor

and replacing it wit RwLock... this simplifies the code and should make it more robust towards parallel requests with the same session id.

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
@dawid-nowak
dawid-nowak requested a review from lucarlig May 18, 2026 12:08

@lucarlig lucarlig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues

Comment thread crates/contextforge-gateway-rs-lib/src/gateway/session_manager.rs
Comment thread crates/contextforge-gateway-rs-lib/src/gateway/session_manager.rs
Comment thread crates/contextforge-gateway-rs-lib/src/gateway/mcp_gateway.rs
Comment thread crates/contextforge-gateway-rs-lib/src/gateway/mcp_gateway.rs
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
@dawid-nowak
dawid-nowak requested a review from lucarlig May 19, 2026 08:28

@lucarlig lucarlig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dawid-nowak
dawid-nowak merged commit 799350c into main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants