Basic tls support and test framework - #2
Merged
Conversation
…quest client Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…tream_tls_support
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
dawid-nowak
force-pushed
the
dawid.nowak/basic_upstream_tls_support
branch
from
May 7, 2026 09:46
4de2fab to
fc963a6
Compare
lucarlig
requested changes
May 7, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
I found only minor stuff
general comments:
-
Private keys are committed under
assets/. Maybe move them into a clearly labeled test fixture folder so it is obvious they are not real deployment material. -
Tests only prove normal TLS works. They do not prove:
- client cert/key loading works
- missing cert/key fails correctly
- a backend requiring a client cert accepts the gateway
- a backend requiring a client cert rejects the gateway without one
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
dawid-nowak
force-pushed
the
dawid.nowak/basic_upstream_tls_support
branch
from
May 7, 2026 10:23
fc963a6 to
403834f
Compare
lucarlig
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling secure communication to downstream/upstream components with tls.
Enabling end to end unit/integration tests.