fix: avoid dumping gateway config in logs - #31
Merged
Conversation
This reverts commit cc92b70.
lucarlig
marked this pull request as ready for review
June 8, 2026 10:26
dawid-nowak
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
println!that dumped the full parsed gateway configUserConfigpayloads after config lookup; log only subject and virtual-host countWhy
The gateway should keep useful operational startup and request context without printing entire configuration objects. Full config and user config dumps can expose sensitive operational details or future credential-bearing runtime config.
Scope
This PR intentionally avoids routing, MCP response handling, and dependency-resolution changes. A broader MCP logging pass should be a separate PR with tests if we want to change those call sites.
Validation
cargo fmt --all --checkcargo check --locked -p contextforge-gateway-rs-lib -p contextforge-gateway-rscargo clippy --locked -p contextforge-gateway-rs-lib -p contextforge-gateway-rs -- -D warningsNote: this branch is based on
main, so the existing unrelatedworkspace.dependencies.rmcp.commitwarning is still emitted until the dependency-pin PR lands.