Skip to content

fix: avoid dumping gateway config in logs - #31

Merged
lucarlig merged 4 commits into
mainfrom
fix/startup-config-logging
Jun 9, 2026
Merged

fix: avoid dumping gateway config in logs#31
lucarlig merged 4 commits into
mainfrom
fix/startup-config-logging

Conversation

@lucarlig

@lucarlig lucarlig commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the startup println! that dumped the full parsed gateway config
  • log a structured startup event through tracing after logging initialization
  • avoid logging full UserConfig payloads after config lookup; log only subject and virtual-host count
  • fix the typo in the configuration retrieval error message touched by this logging path

Why

The gateway should keep useful operational startup and request context without printing entire configuration objects. Full config and user config dumps can expose sensitive operational details or future credential-bearing runtime config.

Scope

This PR intentionally avoids routing, MCP response handling, and dependency-resolution changes. A broader MCP logging pass should be a separate PR with tests if we want to change those call sites.

Validation

  • cargo fmt --all --check
  • cargo check --locked -p contextforge-gateway-rs-lib -p contextforge-gateway-rs
  • cargo clippy --locked -p contextforge-gateway-rs-lib -p contextforge-gateway-rs -- -D warnings

Note: this branch is based on main, so the existing unrelated workspace.dependencies.rmcp.commit warning is still emitted until the dependency-pin PR lands.

@lucarlig lucarlig changed the title fix: avoid dumping startup config fix: clean up gateway startup and config logging Jun 8, 2026
@lucarlig lucarlig changed the title fix: clean up gateway startup and config logging fix: clean up gateway logging output Jun 8, 2026
@lucarlig lucarlig changed the title fix: clean up gateway logging output fix: avoid dumping gateway config in logs Jun 8, 2026
@lucarlig
lucarlig marked this pull request as ready for review June 8, 2026 10:26
@lucarlig
lucarlig requested a review from dawid-nowak June 8, 2026 10:26
@lucarlig
lucarlig merged commit 0fd5636 into main Jun 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants