Allow JWTs without token_use or full_name claims - #54
Merged
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Contributor
Author
|
E2E verification against the live split stack (control plane at IBM/mcp-context-forge main + PR #5482 branch, dataplane image built from this branch):
|
dawid-nowak
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #51. The dataplane still rejects otherwise valid JWTs when the token has no
token_useclaim or when theuserobject has nofull_namefield. ContextForge control-plane admin tokens (e.g. the ones minted by the upstream live-gateway compliance harness) carry neither, so everygateway_virtualprotocol-compliance row still fails with 401 against the split stack even after #51. Verified by claim-stripping against a live deployment: removing either claim from an otherwise accepted token flips the response from 200 to 401, whileusernameandnbfare already optional.Summary
ContextForgeClaims.token_useoptionalUser.full_nameoptionalNone, mirroring the Allow JWTs without scopes claims #51scopeshandlingValidation
cargo test -p contextforge-gateway-rs-lib(31 passed, includes new regression test)cargo fmt --check(no new diffs; pre-existing nightly-only drift untouched)cargo clippy --workspace --all-targets -- -D warningstoken_use/full_namereturns 401 on current 0.1.0; same token accepted after making these claims optional