chore: code quality cleanup#127
Merged
Merged
Conversation
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Puts back the ~25 substantive doc/rationale blocks the comment cleanup over-removed (FFI ABI contract, capability security docs, session-spoofing note, wire-contract refs, bug rationale). Keeps the code improvements and banner/blank-line removals. No code changes; workspace builds and tests pass. Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Strips R#/KD#/C# requirement-plan IDs, E#/Slice/step/sub-step impl-plan labels, P0-#/Finding review IDs, internal spec § refs, and internal plan/spec/design/runbook doc-filename pointers from comments and doc-comments. Reworded prose to read cleanly. Kept T0/T1/T2 session-tier labels and external-standard citations (RFC/OIDC/OAuth §). No behavior changes; workspace builds and 939 tests pass. Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead code across crates and resolves aislop findings, with documentation touch-ups.
Code changes
The PR is ~95% comment and doc cleanup. Actual code changes are confined to three files.
Behavior change
Panic-safety only (no behavior change)
Refactor (pure code movement)
Cleanup (behavior preserving)
Cosmetic (no logic)
No public API, signatures, struct fields, enum variants, dependencies, or test assertions changed.