-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: prevent memory leaks from AbortController in async operations #6126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
✨ No issues found! Your code is sparkling clean! ✨ |
d7bf38e
to
fed3049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, it's a great fix. I do think it would be good to have a quick test for the runWithAbortController
method, since this is going to be on the critical path of every single request. Once there are tests I'm happy to merge!
Description
AbortController instances were not being properly cleaned up after async operations (Promise/AsyncGenerator) completed or failed, leading to potential memory leaks.
Testing
Verified with: