fix(autocomplete): trim trailing <|file_separator|> for Gemini/Gemma #6194
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayden-cardwell
requested review from
tomasz-stefaniak
and removed request for
a team
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
dosubot
bot
added
the
size:XS
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
…models Google Gemini/Gemma models sometimes append "<|file_separator|>" at the end of autocomplete completions, forcing users to remove it manually. Update postprocessCompletion to detect when llm.model includes "gemini" or "gemma" and the completion ends with "<|file_separator|>", then slice off the trailing 18 characters. See continuedev#6067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #6067. Change was made to remove the trailing 18 characters from the completion if the model is a Gemini or Gemma model, and the completion ends with <|file_separator|>. Attempting to do this within:
core/autocomplete/filtering/streamTransforms/lineStream.ts
Resulted in generations not showing.
Checklist
Screenshots
N/A
Tests
I don't believe any tests currently exist for the postprocessing code.