Embeddings chunking fixes #6261
Draft
+521
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allin/embedding-chunking-fixes
…allin/embedding-chunking-fixes
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:XL
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| // `cross-env` seems to make it so __dirname is the root of the project and not the directory containing this file | ||
| return path.join(__dirname, "llm", workerFileName); | ||
| } | ||
| // if (process.env.NODE_ENV === "test") { |
There was a problem hiding this comment.
Commenting out the test environment path handling will break the worker file resolution during tests. The code in build.js and package.json files shows that worker files are moved to different locations during build and testing. Without the test-specific path logic, the tokenizer workers won't be found in the test environment, causing the LlamaAsyncEncoder and GPTAsyncEncoder to fail.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ What changed? Feel free to be brief. ]
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]