refactor: remove History component from GUI layout #6275
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iamshankhadeep
requested review from
tomasz-stefaniak
and removed request for
a team
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
dosubot
bot
added
the
size:XS
|
✨ No issues found! Your code is sparkling clean! ✨ |
|
@sestinj @Patrick-Erichsen pinging for review |
|
We do already have the tab for History, but the decision to show it in this aside is intentional to give a more ChatGPT-esque GUI feel. I think the correct solution is what the request in #6222 was describing, i.e. a button to collapse the history is the user doesn't want to view it. The button state should probably persist in local storage as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR removes the
<History />component from theDefault route, so there will be no history unexpectedly pop up, cause we already haveHistoryas a seperate tab.Checklist
fixes this #6222