Skip to content

Updates on Next Edit PR #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 166 commits into from
Closed

Conversation

jpoly1219
Copy link
Collaborator

@jpoly1219 jpoly1219 commented Jun 28, 2025

Description

  • Resolve reviews from Edit Logging Functionality + Utilities for Next Edit #6268.
  • Fix a bug where SVG will render incorrect texts.
  • Fix a bug where next edit won't be toggled sometimes.
  • Fix a bug where vscode's inline completion provider and next edit's cursor repositioning logic races against each other.
  • General code cleanup for next edit.
  • Added e2e tests for next edit.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

  • e2e tests for next edit.

Summary by cubic

Improved the Next Edit feature with bug fixes, code cleanup, and new end-to-end tests. Also updated build scripts, documentation, and added new rules for protocol messages.

  • Bug Fixes

    • Fixed incorrect SVG text rendering.
    • Fixed Next Edit toggle issues and race conditions with VS Code's inline completion.
    • Addressed code cleanup and improved reliability.
  • Testing

    • Added e2e tests for Next Edit in VS Code.
  • Docs and Rules

    • Updated documentation for prompts and rules.
    • Added new .continue/rules for protocol message guidelines.
  • Build and CI

    • Refactored and sped up build scripts.
    • Improved package build and release workflows.

@jpoly1219 jpoly1219 requested a review from a team as a code owner June 28, 2025 02:34
@jpoly1219 jpoly1219 requested review from RomneyDa and removed request for a team June 28, 2025 02:34
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 28, 2025
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


8 out of 9 committers have signed the CLA.
✅ (RomneyDa)[https://github.com/RomneyDa]
✅ (uinstinct)[https://github.com/uinstinct]
✅ (sestinj)[https://github.com/sestinj]
✅ (tomasz-stefaniak)[https://github.com/tomasz-stefaniak]
✅ (exigow)[https://github.com/exigow]
✅ (Patrick-Erichsen)[https://github.com/Patrick-Erichsen]
✅ (jpoly1219)[https://github.com/jpoly1219]
✅ (adarshramiyer)[https://github.com/adarshramiyer]
@semantic-release-bot
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@jpoly1219 jpoly1219 closed this Jun 30, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Jun 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants