feat: added UI for global rule creation #7467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
4 times, most recently
from
f393f84 to
20b3f89
Compare
panyamkeerthana
changed the title
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
4 times, most recently
from
68ee686 to
383103b
Compare
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
3 times, most recently
from
383103b to
db4bdb1
Compare
panyamkeerthana
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:L
panyamkeerthana
changed the title
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
from
db4bdb1 to
43f464d
Compare
Collaborator
|
@prakashsharma91 mind sharing a screenshot of what this looks like with the new rules section in settings? |
Contributor
Author
Screen.Recording.2025-09-17.at.15.08.45.mov |
Collaborator
|
Nice ! I could see this being useful for all of the "new block" buttons on the settings page. My only nitpick is that I think the select should be incorporated into the "Plus" button itself. We have a button similar to what I'm describing on the hub: 
|
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
from
43f464d to
7b50ed7
Compare
Contributor
Author
|
@Patrick-Erichsen I added a new 
|
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
from
7b50ed7 to
52f86c0
Compare
Patrick-Erichsen
requested changes
Sep 22, 2025
Collaborator
Patrick-Erichsen
left a comment
Patrick-Erichsen
left a comment
There was a problem hiding this comment.
Thanks for implementing the new button! A few nitpicks/polish requests
- The border color/thickness is not the same for the other "add" buttons in settings, it's thinner/lighter
- Nitpick but I prefer just "Add rule" for the tooltip to keep things simple/consistent
- This advanced button should only be visible when the user has "Local agent" select. For hub agents the button doesn't modify anything on your local filesystem, it just opens a link to the hub
- Instead of "Globally" we should say "Global"
- There is a bug with the filepath logic, I clicked "Current workspace" and it correctly added it to the
.continuein my workspace, but then I clicked "Globally" it still added to current workspace. Eventually it sometimes does add globally but it's flaky. - I think the hover effect should be the same as the other buttons, eg a ghost button, rather than the orange fill I'm getting here
- added global mode toggle - implemented conditional styling (white when enabled, gray when disabled) feat: improve global rules UI and fix debug mode issues - added dropdown button component to switch between global and workspace rule creation. - fixed global rules creation to use nested rules/ subdir in debug mode - prevent default glob patterns for global rules by returning undefined globs - generate unique rule names for global rules - added watcher for rules in global directory
panyamkeerthana
force-pushed
the
panyamkeerthana/workspace_global_rules
branch
from
52f86c0 to
8101b08
Compare
dosubot
bot
added
size:XS
Collaborator
|
Looks great, thank you again for the attention to detail here! Excited to get this one merged 🚀 |
Patrick-Erichsen
approved these changes
Oct 1, 2025
Contributor
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a rule scope dropdown in the RulesSection that lets users choose between creating workspace rules or global rules. This sets up the base for managing rules that work across all projects, with updates in the backend and protocol to support global rule creation.
Screen recording or screenshot
Screen.Recording.2025-09-08.at.08.54.07.mov
Summary by cubic
Adds a toggle in RulesSection to choose between creating workspace rules or global rules, enabling global rule files to be created directly from the UI. Connects the UI to a new core handler to write the rule in the global directory and reload config.