Skip to content

Conversation

@exigow
Copy link
Contributor

@exigow exigow commented Sep 2, 2025

Summary by cubic

Reverts the previous auto-recovery change and simplifies core process management. Restart now happens in a dedicated manager with clearer telemetry and proper cleanup.

  • Refactors
    • Added CoreMessengerManager to restart the core on unexpected exit with exponential backoff.
    • ContinueBinaryProcess accepts an onUnexpectedExit callback and reports exit output to Sentry/PostHog.
    • ContinueProcessHandler now only handles IO and close; removed internal restart/backoff logic.
    • CoreMessenger manages its process instance, adds handleMessage, and supports restart/close.
    • Startup and service wiring updated to use CoreMessengerManager; proxy restart path updated.
    • Removed BackoffCalculator and its unit test.

@exigow exigow marked this pull request as ready for review September 2, 2025 15:32
@exigow exigow requested a review from a team as a code owner September 2, 2025 15:32
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 2, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

@exigow exigow merged commit 7c97329 into main Sep 2, 2025
116 of 123 checks passed
@exigow exigow deleted the exigow/revert-restarting branch September 2, 2025 17:28
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 3, 2025

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Sep 3, 2025

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants