-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add per-tab model persistence and selection functionality #8644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ferenci84
wants to merge
8
commits into
continuedev:main
Choose a base branch
from
ferenci84:per-tab-model-persistence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−3
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
70af97e
add per-tab model persistence and selection functionality
ferenci84 de68ac9
persist and restore per-tab mode state in TabBar component and tabsSlice
ferenci84 811391e
Merge branch 'main' into per-tab-model-persistence
ferenci84 6bf5ee1
Merge branch 'main' into per-tab-model-persistence
ferenci84 a3b5ee8
persist session-specific mode and chat model selection across tab swi…
ferenci84 ea6e871
remove unnecessary type assertions and clean up session loading logic
ferenci84 b2f565e
fix: followup on persisted chat model pr
RomneyDa 4b330de
Merge branch 'main' of https://github.com/continuedev/continue into f…
RomneyDa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR's implementation contradicts its stated architectural goal. It re-introduces per-tab state management for model and mode (in
tabsSlice.ts) instead of removing it, and the logic inTabBar.tsxincorrectly uses this tab-level state as the source of truth, overriding the intended session-level persistence.Prompt for AI agents
✅ Addressed in
a3b5ee8