Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 10, 2025

Description

Change the lazy apply prompt for claude sonnet models to not change comments.

resolves CON-2084

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Updated the lazy apply prompt for Claude Sonnet models and all edit/apply prompts to preserve comments unless changes require modifying them. Aligns with CON-2084 by preventing unintended comment edits across lazy applies and code edits.

Written for commit 3c85721. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 10, 2025 12:28
@uinstinct uinstinct requested review from sestinj and removed request for a team November 10, 2025 12:28
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 10, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct could we knock this out for all lazy apply prompts in one go? Or if already done add a comment about why only this one?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 10, 2025
@uinstinct
Copy link
Contributor Author

@uinstinct could we knock this out for all lazy apply prompts in one go? Or if already done add a comment about why only this one?

Sure. Lazy apply prompt only works for sonnet models. Hence only one was changed.

@uinstinct uinstinct requested a review from RomneyDa November 11, 2025 03:08
@RomneyDa
Copy link
Collaborator

RomneyDa commented Nov 12, 2025

Ah you're right I just mean all apply and edit prompts. Removing comments will be an issue for all of them but especially apply, check intellij buildApplyPrompt, apply manager getApplyPrompt. I would also tweak all edit prompts (core/llm/templates/edit) if they say nothing about comments. I think there's 20 ish prompts in core/llm/templates/edit. Some may not even be reachable anymore, if so can skip

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 12, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct thanks! Could we tweak the wording a little bit from Do not change code comments unless explicitly requested to Leave existing comments in place unless changes require modifying them.

I think "explicitly requested" (I know I suggested that) might make it not change comments enough

@uinstinct uinstinct requested a review from RomneyDa November 14, 2025 03:32
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 17, 2025
@sestinj sestinj merged commit d8cc0b6 into continuedev:main Nov 17, 2025
52 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants