-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: sonnet lazy apply prompt should not change comments #8665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct could we knock this out for all lazy apply prompts in one go? Or if already done add a comment about why only this one?
Sure. Lazy apply prompt only works for sonnet models. Hence only one was changed. |
|
Ah you're right I just mean all apply and edit prompts. Removing comments will be an issue for all of them but especially apply, check intellij |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 9 files
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct thanks! Could we tweak the wording a little bit from Do not change code comments unless explicitly requested to Leave existing comments in place unless changes require modifying them.
I think "explicitly requested" (I know I suggested that) might make it not change comments enough
Description
Change the lazy apply prompt for claude sonnet models to not change comments.
resolves CON-2084
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Updated the lazy apply prompt for Claude Sonnet models and all edit/apply prompts to preserve comments unless changes require modifying them. Aligns with CON-2084 by preventing unintended comment edits across lazy applies and code edits.
Written for commit 3c85721. Summary will update automatically on new commits.