Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 19, 2025

Description

readFile in jetbrains has a fallback but readDocument returned empty string. This PR fixes it by returning null so that it can successfully fallback.

closes CON-4770

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes IntelliJ file reading to fall back to vsfutil.loadtext when the editor document is unavailable. Prevents empty content by reading from disk as intended (CON-4770).

  • Bug Fixes
    • Return null instead of "" in readDocument to trigger readFile's vsfutil.loadtext fallback.

Written for commit 82050fc. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 19, 2025 14:56
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team November 19, 2025 14:56
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 19, 2025
@uinstinct
Copy link
Contributor Author

uinstinct commented Nov 19, 2025

need to verify on a build

EDIT: seems to work

@uinstinct uinstinct marked this pull request as draft November 19, 2025 14:56
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@uinstinct uinstinct marked this pull request as ready for review November 20, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant