Skip to content

fix: HOTFIX make errors fetching secrets nonblocking for local configs #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: HOTFIX make errors fetching secrets nonblocking for local configs #8809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/config/yaml/LocalPlatformClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ export class LocalPlatformClient implements PlatformClient {
return [];
}

const results = await this.client.resolveFQSNs(fqsns, this.orgScopeId);
let results: (SecretResult | undefined)[] = [];
try {
results = await this.client.resolveFQSNs(fqsns, this.orgScopeId);
} catch (e) {
console.error("Error getting secrets from control plane", e);
}

// For any secret that isn't found, look in .env files, then process.env
for (let i = 0; i < results.length; i++) {
Expand Down
Loading