Skip to content

Fix stats track and inactive client reaping #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickbrowne merged 2 commits into from
Jan 28, 2025
Merged

Fix stats track and inactive client reaping #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958ea58
Fix stats tracking
nickbrowne Jan 28, 2025
0b6493e
Fix inactive client reaping
nickbrowne Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/server/websocket.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ exports.attach = (server, createAgent, options) ->
if !!options.trackStats
setInterval ->
options.trackStats
activeWebsocketConnections: wss.clients.length
activeWebsocketConnections: wss.clients.size
, STATISTICS_INTERVAL

# Clients send out a heartbeat at 10 second intervals, if
Expand All @@ -61,7 +61,7 @@ exports.attach = (server, createAgent, options) ->
# event, the client would have already established a new connection by the time
# the server terminates it from it's side.
setInterval ->
for client in wss.clients
wss.clients.forEach (client) ->
client.terminate() if !client.isAlive
client.isAlive = false
, CLIENT_TIMEOUT
Loading