fix: Remove the Datadog logging adapter #229
Open
+1
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the Datadog logging adapter. The adapter is only consumed by `go-datalog-lib` and should not have been implemented in `go-logger`. With the V2 changes to `dd-trace-go` removing the sooner than later will make migration to OpenTelemetry or `dd-trace-go` V2 simpler. The functionality is copied into `go-datadog-lib`, see [coopnorge/go-datadog-lib#571][coopnorge/go-datadog-lib#571] for more information. [coopnorge/go-datadog-lib#571]: coopnorge/go-datadog-lib#571
policy-bot-coop-norge
bot
requested review from
arunpoudel,
CRCOOP,
Gjeitnes,
JEHCoop,
karkinissan,
s0nqr3,
tigertore and
yurydavydov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the Datadog logging adapter. The adapter is only
consumed by
go-datalog-liband should not have been implemented ingo-logger.With the V2 changes to
dd-trace-goremoving the sooner than later willmake migration to OpenTelemetry or
dd-trace-goV2 simpler.The functionality is copied into
go-datadog-lib, seecoopnorge/go-datadog-lib#571 for more
information.