fix: improve default readiness probe config for shutdown #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On shutdown coredns will wait what is configured for lameduck and continue handling connections. At the same time it will fail readiness probes.
In order to give readiness checks a chance to remove the instance from the service we need to lower the failure threshold and the interval.
This is to avoid failing DNS requests in a busy cluster when coredns is being scaled down.
Why is this pull request needed and what does it do?
We used a dns-test-container and did the following procedure to get this result:
We configured coredns as it is default by EKS
lameduck 5s
andreadinessProbe: periodSeconds=10s failureThreshold=3
This test was executed in a cluster running ~1000 pods.
With this change in place we get no losses in DNS resolution when repeating this test
Which issues (if any) are related?
The issue is described above.
Checklist:
Changes are automatically published when merged to
main
. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.