Skip to content

Removing jQuery dependency for Bloodhound #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Removing jQuery dependency for Bloodhound #162

wants to merge 7 commits into from

Conversation

jslegers
Copy link

@jslegers jslegers commented Oct 3, 2017

Too many failed unit tests
Nevermind...

* Removing jQuery from Bloodhound
* Adding Jetty server
* Adding demo page to "test"
Most importantlty, a Promise polyfill is added.
@jslegers jslegers changed the title Removing jQuery dependency for Bloodhound Nevermind Oct 3, 2017
@jslegers jslegers closed this Oct 3, 2017
@jlbooker jlbooker changed the title Nevermind Removing jQuery dependency for Bloodhound Oct 4, 2017
@jlbooker
Copy link
Contributor

jlbooker commented Oct 4, 2017

👍 Would be interested in this, @jslegers, if you have more time to work on it. I imagine it is going to be a big job, especially to update all the unit tests.

@jslegers
Copy link
Author

jslegers commented Oct 6, 2017

Would be interested in this, @jslegers, if you have more time to work on it. I imagine it is going to be a big job, especially to update all the unit tests.

Since you asked so nicely, I gave it another shot. This time, everything works as expected.

To avoid including any garbage from my previous attempt, I reforked the project and created a new pull request with only the changes done during my new attempt. See #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants