-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dracut: Correctly add pkey_cca kernel mod for cex card #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add something like the following in your commit message and PR text:
Thanks |
27bd380
to
0c28545
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I meant adding it, not replacing everything. The entire first comment of this PR should be your commit message + the fixes line. |
The previous PR title was also fine, the new one is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhu-pillai the changes look good; the commit message is wrong;
The Fixes: https://github.com/coreos/ignition/issues/2013
should be under the commit message.
i.e
dracut: correctly add pkey_cca kernel module for cex support
fixes:#2013
fixes:coreos#2013 Co-authored-by: Timothée Ravier <[email protected]>
0c28545
to
8e13a8f
Compare
While doing testing hardware disk encryption using cex on
4.19 rhel 9.6
failed to detect cex domain for luks encryption.when run the command in verbose mode folllowing logs found.
IBM suggested that there is split for
pkey
module in kernel version5.14.0-556
pkey
topkey/pkey_cca/pkey_ep11/pkey_pckmo
pkey.ko is now a base module and "handler" modules pkey_cca.ko, pkey_ep11.ko.
You would need the pkey_cca.ko also in your initrd.
I've tested this in zVM, zKVM logs have attached for reference.
PKEY_CEX_DASD_Test.log
PKEY_CEX_FCP_Test.log
PKEY_CEX_KVM_Test.log