cxx: Consider Rust target and features #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
jschwender/cxx
branch
from
f1a23ab to
8085bb4
Compare
The dependency on cxx may be gated behind a feature. We can simply enable all features for dependency resolution though. cxxbridge-cmd also only appears with --target all. We start preferring `cxxbridge-cmd`, since that was recommended by dtolnay. We still fallback to parsing the version of `cxx` to support older cxx versions, where the bridge version may not appear in the dependency tree. In practice this fallback shouldn't cause any problems, since we anyway need to ensure that `cxxbridge version == cxx version`.
jschwe
force-pushed
the
jschwender/cxx
branch
from
8085bb4 to
4488ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on cxx may be gated behind a feature. We can simply enable all features for dependency resolution though.
cxxbridge-cmd also only appears with --target all so we enable all targets.
We start preferring
cxxbridge-cmd, since that was recommended by dtolnay.We still fallback to parsing the version of
cxxto support older cxx versions, where the bridge version may not appear in the dependency tree.In practice this fallback shouldn't cause any problems, since we anyway need to ensure that
cxxbridge version == cxx version.