feat: add Adrapid plugin - #662
Conversation
|
@Vishuzz is attempting to deploy a commit to the corsair Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR registers the You.com provider, adds Jest mappings for shared Corsair modules, improves PostgreSQL test gating when connectivity is unavailable, and makes probe timeout continuation testing deterministic. ChangesProvider registration and test reliability
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment Warning |
Greptile SummaryThis PR registers the existing You.com plugin in the core provider vocabulary and adds Jest aliases needed by its tests. It also includes unrelated changes to two Corsair core test files that violate the repository's plugin-PR scope boundary.
Confidence Score: 2/5This PR should not merge until the unrelated Corsair core test changes are removed or split into a separate pull request. The You.com registration and Jest mapping are internally consistent, but the changeset violates the repository's mandatory plugin scope boundary by modifying two core test files. Files Needing Attention: packages/corsair/tests/postgres-js-database.test.ts, packages/corsair/tests/probe.test.ts Important Files Changed
Reviews (1): Last reviewed commit: "feat: add Adrapid plugin" | Re-trigger Greptile |
| const gated = () => { | ||
| const runner = liveDisabled ? it.skip : it; | ||
| return (name: string, fn: any, timeout?: number) => { | ||
| runner( | ||
| name, | ||
| async (...args: any[]) => { | ||
| if (!connectable) return; | ||
| return fn(...args); | ||
| }, | ||
| timeout, | ||
| ); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Plugin scope boundary is broken
This You.com plugin PR changes PostgreSQL test registration here and probe behavior in packages/corsair/tests/probe.test.ts, outside the permitted plugin directory, provider registry, and lockfile scope. These unrelated core test changes cause the repository's plugin-PR scope gate to fail and need to be removed or split into a separate PR.
Rule Used: A plugin PR must only modify files inside a single... (source)
Knowledge Base Used: The provider-plugin package pattern
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Plugin PR scorecard —
|
| Check | Status | Notes |
|---|---|---|
| R1 — Scope: plugin files only | ❌ | Out of scope: packages/corsair/tests/postgres-js-database.test.ts, packages/corsair/tests/probe.test.ts |
| R2 — Tests with assertions | ✅ | |
| R3 — Description complete | ✅ | |
| R3 — Linked issue / claim | No "Fixes #…" or claim link — add one if this PR has a claim or issue | |
| R4 — Demo video / recording | ❌ | Required in "Screenshots / Demos" before a maintainer reviews |
Rules: PLUGIN_PR_RULES.md · re-runs on every push
|
Hey @Vishuzz, thanks for the contribution! 🏴☠️ Before a maintainer reviews, please fix the items below — the review re-runs automatically on your next push. Must fix
Rule Used: A plugin PR must only modify files inside a single... (source) Knowledge Base Used: The provider-plugin package pattern Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! PR requirements (rules)
If anything remains after your next push, a bot commit will clean it up; a maintainer always does the final review and merge. |
Description
The
youcomplugin is already implemented underpackages/youcom/, but it was missing from the core provider registry.This PR registers
youcominpackages/corsair/core/constants.tsso it is recognized by the core provider system.Changes
youcomtoBaseProviders, alphabetically betweenxquikandyoutubeyoucom: 'You.com'toProviderDisplayNamesyoucomto theAllProvidersunion typepackages/youcom/jest.config.cjswith the required module mappingsVerification
pnpm run validate:plugins— passedpnpm typecheck— passedpnpm lint— passedpnpm --filter @corsair-dev/youcom test— 22/22 tests passedSummary by CodeRabbit
New Features
Tests
Chores