Add parquet shard cache TTL #7098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-paruqet-shard-cache-ttl
branch
2 times, most recently
from
9c55941 to
43d0546
Compare
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-paruqet-shard-cache-ttl
branch
from
43d0546 to
0ce1c39
Compare
yeya24
approved these changes
Nov 17, 2025
| return c, nil | ||
| } | ||
|
|
||
| func (c *Cache[T]) maintenanceLoop(interval time.Duration) { |
Contributor
There was a problem hiding this comment.
Just a note, I think we need to move this cache implementation or some reusable parquet code into a separate package so that store gateway parquet mode can reuse the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a TTL to parquet shard cache. A TTL can be configured by
-querier.parquet-queryable-shard-cache-ttlflag.To reviewers: Which default TTL value would be appropriate?
Which issue(s) this PR fixes:
Fixes #6991
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]