письма и аномалии#620
Open
benjii158 wants to merge 8 commits into
Open
Conversation
агенты больше не бабахают аномы и не воруют письма, ведь отныне этим занимаются клептоманы
github-actions
Bot
added
size/M
S: Needs Review
S: Untriaged
Changes: No C#
and removed
S: Untriaged
labels
Contributor
📝 WalkthroughWalkthroughThis PR adds a MailFraudObjective to thief prototypes, disables SupercritAnomaliesObjective for traitors and removes its group entry, and disables/removes MailFraudObjective from traitor prototypes and traitor objective groups. ChangesObjective Configuration Adjustments
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/Objectives/objectiveGroups.yml`:
- Around line 50-54: The commented-out weightedRandom prototype
"TraitorObjectiveGroupSabotage" causes TraitorObjectiveGroupSabotage: 1 to
reference a missing group and makes ObjectivesSystem.GetRandomObjective return
null; fix by either restoring or removing that prototype or guarding the lookup:
restore the weighted-random prototype block (uncomment the
TraitorObjectiveGroupSabotage weightedRandom definition) or update
ObjectivesSystem.GetRandomObjective to check for a missing group id after
selection and skip or fallback (e.g., continue to next weight or choose a
default group) instead of returning null; reference the
TraitorObjectiveGroupSabotage id in objectiveGroups.yml and the
GetRandomObjective method in ObjectivesSystem when applying the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 429ca1c7-0430-47d5-81e3-694949da5282
📒 Files selected for processing (3)
Resources/Prototypes/Objectives/objectiveGroups.ymlResources/Prototypes/Objectives/thief.ymlResources/Prototypes/Objectives/traitor.yml
oldschoolotaku
requested changes
May 22, 2026
oldschoolotaku
left a comment
oldschoolotaku
left a comment
Collaborator
There was a problem hiding this comment.
- коменты - потеряно
- глянь последний ревью. у тебя это тесты кладет
| title: objective-condition-supercrit-anomalies-title | ||
| - type: ObjectiveLimit | ||
| limit: 1 | ||
| #q- type: entity |
Collaborator
There was a problem hiding this comment.
не обязательно коментить. достаточно было вырезать из пулла тасок
Co-authored-by: nukkuminen <90336027+oldschoolotaku@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/Objectives/traitor.yml`:
- Line 421: The active "parent: [BaseThiefObjective, BaseCounterObjective]" line
is inside a disabled/commented-out entity block and breaks YAML parsing; either
comment out that parent line (so it becomes part of the disabled block) or
remove the entire disabled entity block; look for the traitor entity definition
containing the parent declaration and update the "parent: [BaseThiefObjective,
BaseCounterObjective]" line (previously changed from BaseTraitorObjective)
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 42d0ad2d-b184-4ad4-9f4a-032b017a226b
📒 Files selected for processing (1)
Resources/Prototypes/Objectives/traitor.yml
Co-authored-by: nukkuminen <90336027+oldschoolotaku@users.noreply.github.com>
учел замечания отаку и просто все вырезал нахер
еще немного вырезанного по просьбе отаку
олдскул отаку сделала так чтобы на локалке все ложилось нахуй, отныне буду чинить тесты
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Resources/Prototypes/Objectives/traitor.yml (1)
399-415: 💤 Low valueConsider removing commented code entirely.
The entire
MailFraudObjectiveentity is commented out and appears to be moved tothief.yml(per PR stack). Keeping commented-out prototypes in the codebase can create maintenance confusion, especially since Line 400 modifies theparentfield within the comment itself.🧹 Suggested cleanup
Remove lines 399-415 entirely rather than keeping them as comments, since the objective has been moved to the thief prototype file.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Objectives/traitor.yml` around lines 399 - 415, Remove the dead commented-out MailFraudObjective block from traitor.yml: delete the entire commented prototype that defines MailFraudObjective (the commented-parent change from BaseTraitorObjective to BaseThiefObjective and its components: Objective, MailFraudCondition, NumberObjective, ObjectiveLimit) since that prototype was moved to the thief prototype file; this avoids stale commented code and potential confusion.Resources/Prototypes/Objectives/objectiveGroups.yml (1)
50-54: 💤 Low valueConsider removing commented objective group definition.
The
TraitorObjectiveGroupSabotageweightedRandom block is disabled and no longer referenced (Line 9 is also commented out). Removing these commented lines would reduce maintenance burden and avoid confusion about whether this code might be re-enabled.🧹 Suggested cleanup
Remove lines 50-54 entirely since the sabotage objective group is being permanently disabled for traitors.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Objectives/objectiveGroups.yml` around lines 50 - 54, Remove the disabled weightedRandom objective group by deleting the commented block for TraitorObjectiveGroupSabotage (the lines containing "type: weightedRandom", "id: TraitorObjectiveGroupSabotage" and its "weights" subsection) so the file no longer contains that commented-out definition; this cleans up the unused Sabotage objective reference and avoids confusion about re-enabling it later.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Resources/Prototypes/Objectives/objectiveGroups.yml`:
- Around line 50-54: Remove the disabled weightedRandom objective group by
deleting the commented block for TraitorObjectiveGroupSabotage (the lines
containing "type: weightedRandom", "id: TraitorObjectiveGroupSabotage" and its
"weights" subsection) so the file no longer contains that commented-out
definition; this cleans up the unused Sabotage objective reference and avoids
confusion about re-enabling it later.
In `@Resources/Prototypes/Objectives/traitor.yml`:
- Around line 399-415: Remove the dead commented-out MailFraudObjective block
from traitor.yml: delete the entire commented prototype that defines
MailFraudObjective (the commented-parent change from BaseTraitorObjective to
BaseThiefObjective and its components: Objective, MailFraudCondition,
NumberObjective, ObjectiveLimit) since that prototype was moved to the thief
prototype file; this avoids stale commented code and potential confusion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5af47dd7-58c7-41d5-a677-b55a0b66e490
📒 Files selected for processing (3)
Resources/Prototypes/Objectives/objectiveGroups.ymlResources/Prototypes/Objectives/thief.ymlResources/Prototypes/Objectives/traitor.yml
💤 Files with no reviewable changes (1)
- Resources/Prototypes/Objectives/thief.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
агенты больше не бабахают аномы и не воруют письма, ведь отныне этим занимаются клептоманы
Описание PR
цель на кражу писем перенесена от агента к вору, а также полностью вырезана цель на коллапс аномалий
Почему / Баланс
таск
Технические детали
полностью удалена возможность выдачи и выпадения цели на коллапс аномалии, возможность выдачи и выпадения цели на письма у агентов. однако цель на письма была перенесена к вору, со всеми подвязками.
Медиа
не требуется (что показывать, ВС код?)
Требования
Согласие с условиями
Критические изменения
отсутствуют
Список изменений
🆑 benjamin
Summary by CodeRabbit
New Features
Changes