Skip to content

резисты дракону#632

Open
benjii158 wants to merge 4 commits into
corvax-team:masterfrom
benjii158:drago-resist
Open

резисты дракону#632
benjii158 wants to merge 4 commits into
corvax-team:masterfrom
benjii158:drago-resist

Conversation

@benjii158

@benjii158 benjii158 commented May 30, 2026

Copy link
Copy Markdown
Contributor

Описание PR

дракон получил резисты 75% от взрывов и 60% от огня

Почему / Баланс

таск + дракон нередко умирает от своих же фаерболов + не логично же, что он полностью восприимчив к взрывам и огню. он дышит взрывами и огнем же йоу

Технические детали

добавлен компонент Armor

Медиа

drago

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Критические изменения

Список изменений

🆑 benjamin

  • wl-add: Добавлены резисты для дракона

Summary by CodeRabbit

  • Balance Changes
    • Dragons now have enhanced resistance to piercing and slashing attacks
    • Dragons now have significantly increased resistance to explosive damage

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@benjii158, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7b0a5548-2b9d-4157-8226-efb9cee11bcb

📥 Commits

Reviewing files that changed from the base of the PR and between ff4cde1 and 7c96c07.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Mobs/Player/dragon.yml
📝 Walkthrough

Walkthrough

This PR adds defensive combat configuration to the dragon mob entity by introducing Armor and ExplosionResistance components that define damage resistance against heat, piercing, slash, and explosive attacks. A minor whitespace formatting adjustment is also applied to the ActionGun component declaration.

Changes

Dragon defensive combat

Layer / File(s) Summary
Dragon armor and explosion resistance
Resources/Prototypes/Entities/Mobs/Player/dragon.yml
BaseMobDragon adds Armor component with Heat 0.40, piercing 0.75, and slash 0.85 damage coefficients, and ExplosionResistance component with damageCoefficient 0.25. MobDragon ActionGun declaration line whitespace is adjusted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

A dragon spreads its armored scales,
Heat-proof and sharp-blade-tough—
Explosions bounce? No worries there!
One tough hatchling, that's for sure. 🐉✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'резисты дракону' (resistances for dragon) directly aligns with the main change: adding Armor and ExplosionResistance components to the dragon entity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ибо легко беднягу застрелять тупо
@github-actions github-actions Bot added size/S and removed size/XS labels May 30, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/Entities/Mobs/Player/dragon.yml`:
- Line 201: Remove the trailing whitespace after the "ActionGun" token in the
dragon.yml file (the line currently reads "type: ActionGun "); update the "type:
ActionGun" line to have no trailing spaces to restore consistent formatting in
the Player mob definition.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c39b945-41fa-45e0-bc75-be3c5f8db4d9

📥 Commits

Reviewing files that changed from the base of the PR and between fc06a6f and ff4cde1.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Mobs/Player/dragon.yml

mindRoles:
- MindRoleDragon
- type: ActionGun
- type: ActionGun

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove trailing whitespace.

Line 201 has trailing whitespace after ActionGun that should be removed to maintain formatting consistency.

✨ Proposed fix
-  - type: ActionGun 
+  - type: ActionGun
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: ActionGun
- type: ActionGun
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/Entities/Mobs/Player/dragon.yml` at line 201, Remove the
trailing whitespace after the "ActionGun" token in the dragon.yml file (the line
currently reads "type: ActionGun "); update the "type: ActionGun" line to have
no trailing spaces to restore consistent formatting in the Player mob
definition.

@oldschoolotaku oldschoolotaku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. нет наших коментов
  2. вот так прятать броню у сущности
Image

Comment thread Resources/Prototypes/Entities/Mobs/Player/dragon.yml Outdated
Comment thread Resources/Prototypes/Entities/Mobs/Player/dragon.yml Outdated
mindRoles:
- MindRoleDragon
- type: ActionGun
- type: ActionGun

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?????

benjii158 and others added 2 commits May 30, 2026 20:30
Co-authored-by: nukkuminen <90336027+oldschoolotaku@users.noreply.github.com>
Co-authored-by: nukkuminen <90336027+oldschoolotaku@users.noreply.github.com>

@oldschoolotaku oldschoolotaku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

коментарии

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants