Fix health analyzer#677
Conversation
📝 WalkthroughWalkthroughAdds seven ChangesHealth Analyzer Rating Display
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Locale/ru-RU/_Offbrand/health-analyzer.ftl`:
- Around line 1-9: The variant keys in the health-analyzer-rating Fluent
selector use lowercase names (good, okay, poor, bad, awful, dangerous) but the
MetricRanking enum values are defined in PascalCase (Good, Okay, Poor, Bad,
Awful, Dangerous). Since Fluent selectors are case-sensitive and the UI passes
the enum's ToString() output which returns PascalCase, the keys will never match
and all ratings will fall through to the *[other] case. Fix this by changing all
variant keys in the health-analyzer-rating selector from lowercase to
PascalCase: [good] becomes [Good], [okay] becomes [Okay], [poor] becomes [Poor],
[bad] becomes [Bad], [awful] becomes [Awful], and [dangerous] becomes
[Dangerous] to match the actual enum values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 76302783-2786-4563-8ae4-60c44c97d4ce
📒 Files selected for processing (7)
Content.Client/HealthAnalyzer/UI/HealthAnalyzerControl.xamlContent.Client/HealthAnalyzer/UI/HealthAnalyzerControl.xaml.csContent.Client/HealthAnalyzer/UI/Tooltips/StaticTooltip.xamlContent.Client/HealthAnalyzer/UI/Tooltips/TemperatureTooltip.xamlContent.Client/HealthAnalyzer/UI/Tooltips/UpdatableTooltip.xamlContent.Shared/_Offbrand/Wounds/WoundableHealthAnalyzer.csResources/Locale/ru-RU/_Offbrand/health-analyzer.ftl
Описание PR
Починены кнопки помощи, возращены метки оценки состояния.
Почему / Баланс
фикс
Технические детали
Медиа
#440
Требования
Согласие с условиями
Критические изменения
Список изменений
Summary by CodeRabbit
New Features
Style