Skip to content

Contractor officer значок#682

Merged
oldschoolotaku merged 2 commits into
corvax-team:masterfrom
pomavaReal:ContractorOfficer
Jun 24, 2026
Merged

Contractor officer значок#682
oldschoolotaku merged 2 commits into
corvax-team:masterfrom
pomavaReal:ContractorOfficer

Conversation

@pomavaReal

@pomavaReal pomavaReal commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Описание PR

в лодауты офицерам вместе со званиями добавлен белый значок Внештатный офицер

Почему

фулл лор компатибилити

Медиа

Снимок экрана 2026-06-17 183820 Снимок экрана 2026-06-17 183842

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Список изменений
🆑

  • wl-add: Добавлено веселье в виде значка внештатного офицера!

Summary by CodeRabbit

  • New Features
    • Added a new security contractor neck pin and badge rank variant.
    • The new item is now available in several security-related loadout groups, including officer and specialist roles.
    • Added Russian localization for the new security contractor label and description.
    • Added supporting white visual states for the new badge appearance.

@github-actions

Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit 0900114 merging into b9dd17a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_WL/Clothing/Neck/Pins/security_badges.rsi

State Old New Status
icon-whi Added
whi-equipped-NECK Added

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new contractor security neck pin item (ClothingNeckSecurityContractorPin) with a white sprite variant, a new security-badge-rank-contractor badge rank, a loadout definition, assignment to six security badge groups, and Russian locale entries.

Changes

Contractor Security Pin

Layer / File(s) Summary
Entity definition and sprite states
Resources/Prototypes/_WL/Entities/Clothing/Neck/Pins/security_pins.yml, Resources/Textures/_WL/Clothing/Neck/Pins/security_badges.rsi/meta.json
Defines ClothingNeckSecurityContractorPin inheriting from ClothingNeckSecurityPinBase with icon-whi sprite state and security-badge-rank-contractor rank; adds icon-whi and whi-equipped-NECK RSI states with updated copyright attribution.
Loadout definition and badge group wiring
Resources/Prototypes/_WL/Loadouts/Jobs/Security/badges.yml, Resources/Prototypes/_WL/Loadouts/Groups/security_badges.yml
Inserts SecurityContractorPin loadout mapped to ClothingNeckSecurityContractorPin and adds it to BrigMedicBadges, OfficerBadges, DetectiveBadges, PilotBadges, InstructorBadges, and WardenBadges groups.
Russian localization
Resources/Locale/ru-RU/_WL/security/security_badges_component.ftl, Resources/Locale/ru-RU/_WL/entities/clothing/neck/pins/security_pins.ftl
Adds security-badge-rank-contractor rank string ("Внештатный офицер") and name/description for ent-ClothingNeckSecurityContractorPin in Russian.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • corvax-team/ss14-wl#394: Introduces the SecurityBadgeComponent/SecurityBadgeSystem that reads the rankLoc field this PR populates via security-badge-rank-contractor.

Suggested labels

Changes: Sprites, Changes: Localization, Changes: No C#, S: Untriaged, S: Needs Review, size/S

Suggested reviewers

  • tau27
  • Litogin

Poem

🐇 A white pin appears upon the neck,
The contractor hops in — passed every check!
Six badge groups updated, the loadout is set,
Russian strings added, no detail forget.
Внештатный офицер — the station's new guest! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly matches the main change: adding the contractor officer badge/pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oldschoolotaku oldschoolotaku merged commit e0036f1 into corvax-team:master Jun 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants