Skip to content

Микрофиксики#685

Open
oldschoolotaku wants to merge 2 commits into
corvax-team:masterfrom
oldschoolotaku:fuck-glass
Open

Микрофиксики#685
oldschoolotaku wants to merge 2 commits into
corvax-team:masterfrom
oldschoolotaku:fuck-glass

Conversation

@oldschoolotaku

@oldschoolotaku oldschoolotaku commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Описание PR

Из спавнера рандомных напитков вырезаны коктейли(белый, мясной, синий, робо).
Пакетики соусов снова имеют свои законные 5 единиц соуса

Почему / Баланс

Коктейли сломаны нахуй. И зачем они в спавнере - никому включая визден неизвестно
За пакетики обидно. И поваров тоже

Технические детали

Мейнтейнера во дворца, мейнтейнера во дворца. Закоменть то, измени циферку там.

Медиа

нет

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Список изменений
🆑

  • wl-remove: Вырезан мясной, белый, синий и робо коктейль из спавнера.
  • wl-tweak: В пакетиках соусов снова 5 единиц соуса, заместо 1 единицы

Summary by CodeRabbit

  • Bug Fixes

    • Adjusted condiment packets so they hold and dispense a more appropriate amount.
    • Updated several condiment packets to provide a fuller serving when used.
  • Content Changes

    • Reduced the set of random drinks that can appear from the glass drink spawner, making its output more limited and consistent.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e7e4c9ff-e2ec-4db9-b051-69ee2327a08d

📥 Commits

Reviewing files that changed from the base of the PR and between 4df033f and 53ab3a2.

📒 Files selected for processing (2)
  • Resources/Prototypes/Entities/Markers/Spawners/Random/Food_Drinks/drinks_glass.yml
  • Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/condiments.yml

📝 Walkthrough

Walkthrough

Random drink glass spawn tables now omit four shake entries. Condiment packet prototypes now hold five units of solution and use reagent quantities of five.

Changes

Random Drink Glass Spawn Table

Layer / File(s) Summary
Glass spawn list pruning
Resources/Prototypes/Entities/Markers/Spawners/Random/Food_Drinks/drinks_glass.yml
DrinkShakeBlue, DrinkShakeWhite, DrinkShakeMeat, and DrinkShakeRobo are commented out of the RandomDrinkGlass child lists.

Condiment Packet Capacity and Contents

Layer / File(s) Summary
Packet volume and amounts
Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/condiments.yml
BaseFoodCondimentPacket increases maxVol to 5, and the listed condiment packet entities set their reagent Quantity values to 5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

size/S

Suggested reviewers

  • tau27

Poem

A bunny peeks with a twitchy nose,
Fewer shakes now where the glass stream flows.
Five drops in each packet, neat and spry,
Hop-hop! The pantry patch floats by. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and does not describe the actual changes in drink spawning or condiment packet contents. Use a concise title that names the main change, such as removing broken drink spawns and restoring condiment packet amounts.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tau27 tau27 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб сделать временную миграцию? Чтоб если что с карт поудалять.

@oldschoolotaku

oldschoolotaku commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator Author

Мб сделать временную миграцию? Чтоб если что с карт поудалять.

В спавнере все уже обновлено, эти напитки спавниться не будут. С пакетиками соли как-будто не критично?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants