Skip to content

Convert overviewpy to be more object oriented #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: feature-summarizer
Choose a base branch
from

Conversation

ba66e77
Copy link

@ba66e77 ba66e77 commented Jul 29, 2023

As discussed in Issue #14, we're going to look at making overviewpy more object oriented so we have a consistent style of coding once PR #17 is merged.

This PR:

  • Creates an Overview class which encapsulates the functionality of overviewpy.py
  • Converts the existing functions to invoke the class method versions
  • Uncomments and corrects the unit tests for overviewpy_na

ba66e77 added 4 commits July 29, 2023 06:45
…king those functions delegate calls to the class methods of the same name.
…e. Wrapping show statement in an optional flag.
@cosimameyer
Copy link
Owner

Thank you so much! I'll get a chance to look at both PRs on Monday :)

@cosimameyer cosimameyer changed the base branch from main to feature-summarizer July 31, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants