-
Notifications
You must be signed in to change notification settings - Fork 22
PR313 follow-up: proposed config and arguments format #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cosipy_pipeline
Are you sure you want to change the base?
Conversation
Signed-off-by: Israel Martinez <[email protected]>
… beginning to get a more meaningful error message Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
* Make it work for multiple sources * Display the median and error for all free parameters Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Signed-off-by: Israel Martinez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Hello Israel, I started testing this. Let me know how we proceed. Will you implement the comments and then merge in my branch, or the other way around? In any case, for now, I noticed the following: ii) I tested the time cuts, and they work for me. However, all the functions that are called there need numerical values as input, not a Time object. Thus, I made everything work by adding tstart.value/tstop.value anywhere in lines 103-108 of task.py. My working example is grb of 88s of dc3, however I'll think about how an example for this using the internal test_data of cosipy. iii) maybe it would be useful to add the option of adding a user-defined prefix or suffix to the names of the outputs? Since everything does not get overwritten by default, maybe one wants to keep track of which source is being fitted directly in the names of the output files. Cheers, |
Same functionality as #313, but I'm changing the config file and argparse arguments with a proposed general format.