fix: Make ioctl calls compatible with musl #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ioctl` implementation in glibc takes `unsigned long int`[0]. The musl implementation takes `int`[1]. That causes incompatibility, since the `libc::ioctl` wrapper expects `c_int` on musl targets. Given that `ioctl` is just a regular syscall handled by the Linux kernel, use `libc::syscall` directly, so we don't have to deal with the integer types. [0] https://elixir.bootlin.com/glibc/glibc-2.41.9000/source/misc/sys/ioctl.h#L42 [1] https://elixir.bootlin.com/musl/v1.2.5/source/include/stropts.h#L133
Collaborator
|
Works nicely, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ioctlimplementation in glibc takesunsigned long int[0]. The musl implementation takesint[1]. That causes incompatibility, since thelibc::ioctlwrapper expectsc_inton musl targets.Given that
ioctlis just a regular syscall handled by the Linux kernel, uselibc::syscalldirectly, so we don't have to deal with the integer types.[0] https://elixir.bootlin.com/glibc/glibc-2.41.9000/source/misc/sys/ioctl.h#L42
[1] https://elixir.bootlin.com/musl/v1.2.5/source/include/stropts.h#L133
Checklist