Added Disk Usage Statistics#49
Merged
Merged
Conversation
rwxroot
reviewed
Jul 2, 2026
ada4a
requested changes
Jul 2, 2026
ada4a
approved these changes
Jul 3, 2026
ada4a
left a comment
ada4a
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you:)
Could you please squash down the commits?
Both values can be showcased via "{disk_read}" and "{disk_write}" in
MB/s
Contributor
Author
|
Should be done. Thanks for the quick response. |
Collaborator
|
@ErenYeager1709 @ada4a Thank you for the great work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I wanted to add support for displaying disk read and write values.
The read/write values of all disks (or more precisely, all mount points) are summed up and displayed as a single value.
I used a HashSet to filter out duplicate devices because disks.list() returns a list of mount points and not a list of drives or partitions. In my case, both "/" and "/home" are mounted from the same partition. Since the read/write statistics are tied to the partitions rather than the mount points, iterating over all mount points caused my partition to be counted twice.
By keeping track of the partition names in a HashSet, each partition is only counted once, preventing duplicated read/write values.