Update get_rfi_mask to work with Python 3.11#17
Open
antrikshdhand wants to merge 12 commits intocosmo-ethz:masterfrom
Open
Update get_rfi_mask to work with Python 3.11#17antrikshdhand wants to merge 12 commits intocosmo-ethz:masterfrom
get_rfi_mask to work with Python 3.11#17antrikshdhand wants to merge 12 commits intocosmo-ethz:masterfrom
Conversation
Author
|
get_rfi_mask to work with Python 3.11get_rfi_mask to work with Python 3.11
Collaborator
|
Hi Antriksh thanks for contributing. Do you want to merge this or is it still work in progress? |
Author
|
Hi Joel, no worries! It should be good to merge. I haven't thoroughly tested the code, but I have only majorly changed the following files:
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to allow developers to use the get_rfi_mask() function on Python 3.11. The rest of the code functionality is untouched. New developers should now be able to clone the repository, create a virtual environment, install the requirements listed in requirements-rfi.txt, and run example_rfi.py, which runs the SEEK SumThreshold algorithm on a spectrogram image.
This required a few changes to the code: