Skip to content

fix: support amino encoding on MsgRecoverClient #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtieri
Copy link
Member

@jtieri jtieri commented May 30, 2025

Description

This PR adds amino encoding support to MsgRecoverClient so that txs that include this msg type can be signed via Ledger devices.

It would be great if these changes could get backported to v8 as well.

closes: #8447


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (ed5789b) to head (fb24605).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8448   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files         299      299           
  Lines       21518    21521    +3     
=======================================
+ Hits        13281    13284    +3     
  Misses       7644     7644           
  Partials      593      593           
Flag Coverage Δ
08-wasm 66.28% <ø> (ø)
e2e 1.18% <ø> (ø)
ibc-go 67.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsgRecoverClient does not support amino encoding
3 participants