Skip to content

feat: Check Docker image existence in SetImage method #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Check Docker image existence in SetImage method #2585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/e2e/test_target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ func (dc *DockerContainer) GetTargetConfig() TargetConfig {
func (dc *DockerContainer) SetImage(image string) error {
dc.ImageName = image
// TODO: check if image exists
// Check if the image exists
cmd := exec.Command("docker", "image", "inspect", image)
if err := cmd.Run(); err != nil {
return fmt.Errorf("docker image '%s' not found: %v", image, err)
}
return nil
}

Expand Down