Skip to content

refactor: optimize error creation in DisabledModulesDecorator.AnteHandle #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: optimize error creation in DisabledModulesDecorator.AnteHandle #2591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/consumer/ante/disabled_modules_ante.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@ func NewDisabledModulesDecorator(disabledModules ...string) DisabledModulesDecor

func (dmd DisabledModulesDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (newCtx sdk.Context, err error) {
currHeight := ctx.BlockHeight()
errorMsg := fmt.Errorf("tx contains message types from unsupported modules at height %d", currHeight)

for _, msg := range tx.GetMsgs() {
if hasDisabledModuleMsgs(msg, dmd.prefixes...) {
return ctx, fmt.Errorf("tx contains message types from unsupported modules at height %d", currHeight)
return ctx, errorMsg
}

// Check if there is an attempt to bypass disabled module msg
// with authz MsgExec
if nestedAuthzMsgExecCheck(msg, dmd.prefixes...) {
return ctx, fmt.Errorf("tx contains message types from unsupported modules at height %d", currHeight)
return ctx, errorMsg
}
}

Expand Down