-
Notifications
You must be signed in to change notification settings - Fork 446
feat: add new accordion particles #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@akash3444 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 13 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/ui/registry/registry-examples.ts">
<violation number="1" location="apps/ui/registry/registry-examples.ts:50">
accordion-multi-level pulls Collapsible components but the registryDependencies only include the accordion package, so installing this example will fail because the collapsible package is missing.</violation>
</file>
<file name="apps/ui/registry/default/examples/accordion-tabs.tsx">
<violation number="1" location="apps/ui/registry/default/examples/accordion-tabs.tsx:10">
Please use the `type="multiple"` prop instead of `multiple={true}`; the Base UI accordion mirrors the Radix API, so this prop is ignored and the demo still behaves like a single-select accordion.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
- Introduced multiple accordion particles: "accordion-with-icon", "accordion-multi-level", "accordion-table", and "accordion-tabs".
72f7ba0 to
958425c
Compare
|
Hey @akash3444 , thanks a lot for contributing, we really appreciate it! I just need to ask you to adjust a few things:
<AccordionItem
value="item-1"
className="rounded-xl border last:border-b relative shadow-xs before:pointer-events-none before:absolute before:inset-0 before:rounded-[calc(var(--radius-xl)-1px)] before:shadow-[0_1px_--theme(--color-black/4%)] dark:bg-clip-border dark:before:shadow-[0_-1px_--theme(--color-white/8%)]"
/>
|
|
Hey @pasqualevitiello! Thanks a lot for the detailed feedback and for pointing me in the right direction. I noticed a few components inside the I’ll also tweak the styles to match the coss UI look and feel as much as possible. |
|
no worries, @akash3444! |
Screen.Recording.2025-10-19.at.2.34.56.PM.mov
Summary by cubic
Adds four new accordion particles—accordion-with-icon, accordion-multi-level, accordion-table, and accordion-tabs—now available in the UI registry and particles.