Pasquale/cui 29 search page #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…h-page # Conflicts: # apps/ui/registry/default/particles/index.tsx
…d functionality and consistency
… guidelines for clarity
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 1148 files
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="apps/ui/public/r/p-autocomplete-13.json">
<violation number="1" location="apps/ui/public/r/p-autocomplete-13.json:16">
Add `@coss/button` to the registryDependencies list so the generated particle includes the button package it imports.</violation>
</file>
<file name="apps/ui/content/docs/components/field.mdx">
<violation number="1" location="apps/ui/content/docs/components/field.mdx:114">
The className for the "With Validity" preview introduces a space inside the Tailwind arbitrary variant, yielding invalid classes and breaking the width constraint on the preview.</violation>
</file>
<file name="apps/ui/app/particles/particle-card-container.tsx">
<violation number="1" location="apps/ui/app/particles/particle-card-container.tsx:19">
Add a positioning context (e.g., `relative`) to the content panel so its `::before` pseudo-element is scoped to the panel instead of the entire card body.</violation>
</file>
<file name="apps/ui/public/r/p-breadcrumb-1.json">
<violation number="1" location="apps/ui/public/r/p-breadcrumb-1.json:13">
This particle imports and renders Button, but @coss/button is missing from registryDependencies, so downstream registry builds won’t include the required UI component.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "className": "**:data-[slot=preview]:w-full **:data-[slot=preview]:max-w-64" | ||
| }, | ||
| "name": "p-autocomplete-13", | ||
| "registryDependencies": ["@coss/autocomplete", "@coss/form", "@coss/field"], |
Contributor
There was a problem hiding this comment.
Add @coss/button to the registryDependencies list so the generated particle includes the button package it imports.
Prompt for AI agents
Address the following comment on apps/ui/public/r/p-autocomplete-13.json at line 16:
<comment>Add `@coss/button` to the registryDependencies list so the generated particle includes the button package it imports.</comment>
<file context>
@@ -0,0 +1,18 @@
+ "className": "**:data-[slot=preview]:w-full **:data-[slot=preview]:max-w-64"
+ },
+ "name": "p-autocomplete-13",
+ "registryDependencies": ["@coss/autocomplete", "@coss/form", "@coss/field"],
+ "type": "registry:block"
+}
</file context>
Suggested change
| "registryDependencies": ["@coss/autocomplete", "@coss/form", "@coss/field"], | |
| "registryDependencies": ["@coss/autocomplete", "@coss/form", "@coss/field", "@coss/button"], |
| name="field-validity" | ||
| className="[&_.preview>*]:w-full [&_.preview>*]:max-w-80" | ||
| <ComponentPreview name="p-field-5" | ||
| className="[& .preview>*]:w-full [&_.preview>*]:max-w-80" |
Contributor
There was a problem hiding this comment.
The className for the "With Validity" preview introduces a space inside the Tailwind arbitrary variant, yielding invalid classes and breaking the width constraint on the preview.
Prompt for AI agents
Address the following comment on apps/ui/content/docs/components/field.mdx at line 114:
<comment>The className for the "With Validity" preview introduces a space inside the Tailwind arbitrary variant, yielding invalid classes and breaking the width constraint on the preview.</comment>
<file context>
@@ -100,109 +96,72 @@ import { Input } from "@/components/ui/input"
- name="field-validity"
- className="[&_.preview>*]:w-full [&_.preview>*]:max-w-80"
+<ComponentPreview name="p-field-5"
+ className="[& .preview>*]:w-full [&_.preview>*]:max-w-80"
/>
</file context>
Suggested change
| className="[& .preview>*]:w-full [&_.preview>*]:max-w-80" | |
| className="[&_.preview>*]:w-full [&_.preview>*]:max-w-80" |
| className, | ||
| )} | ||
| > | ||
| <div className="-m-px flex min-h-50 min-w-0 flex-1 flex-col flex-wrap items-center justify-center overflow-x-auto rounded-t-xl rounded-b-lg border bg-background p-6 before:pointer-events-none before:absolute before:inset-0 before:rounded-[calc(var(--radius-xl)-1px)] lg:px-8 lg:py-12 dark:before:shadow-[0_-1px_--theme(--color-white/8%)]"> |
Contributor
There was a problem hiding this comment.
Add a positioning context (e.g., relative) to the content panel so its ::before pseudo-element is scoped to the panel instead of the entire card body.
Prompt for AI agents
Address the following comment on apps/ui/app/particles/particle-card-container.tsx at line 19:
<comment>Add a positioning context (e.g., `relative`) to the content panel so its `::before` pseudo-element is scoped to the panel instead of the entire card body.</comment>
<file context>
@@ -0,0 +1,25 @@
+ className,
+ )}
+ >
+ <div className="-m-px flex min-h-50 min-w-0 flex-1 flex-col flex-wrap items-center justify-center overflow-x-auto rounded-t-xl rounded-b-lg border bg-background p-6 before:pointer-events-none before:absolute before:inset-0 before:rounded-[calc(var(--radius-xl)-1px)] lg:px-8 lg:py-12 dark:before:shadow-[0_-1px_--theme(--color-white/8%)]">
+ {children}
+ </div>
</file context>
| } | ||
| ], | ||
| "name": "p-breadcrumb-1", | ||
| "registryDependencies": ["@coss/breadcrumb", "@coss/menu"], |
Contributor
There was a problem hiding this comment.
This particle imports and renders Button, but @coss/button is missing from registryDependencies, so downstream registry builds won’t include the required UI component.
Prompt for AI agents
Address the following comment on apps/ui/public/r/p-breadcrumb-1.json at line 13:
<comment>This particle imports and renders Button, but @coss/button is missing from registryDependencies, so downstream registry builds won’t include the required UI component.</comment>
<file context>
@@ -0,0 +1,15 @@
+ }
+ ],
+ "name": "p-breadcrumb-1",
+ "registryDependencies": ["@coss/breadcrumb", "@coss/menu"],
+ "type": "registry:block"
+}
</file context>
Suggested change
| "registryDependencies": ["@coss/breadcrumb", "@coss/menu"], | |
| "registryDependencies": ["@coss/breadcrumb", "@coss/menu", "@coss/button"], |
sean-brydon
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Built a unified particles search page with multi-category filtering and chip-based UI, replacing the old category routes. Addresses Linear CUI-29 by making components easier to find and share.
New Features
Refactors
Written for commit 49c2704. Summary will update automatically on new commits.