-
Notifications
You must be signed in to change notification settings - Fork 446
feat(filed): add field item component #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anxndsgn
wants to merge
11
commits into
cosscom:main
Choose a base branch
from
anxndsgn:add-field-item
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anxndsgn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 11 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/ui/public/r/p-radio-group-5.json">
<violation number="1" location="apps/ui/public/r/p-radio-group-5.json:16">
P3: Inconsistent leading space in label text. The Next.js label has `<FieldLabel> Next.js</FieldLabel>` with a space after the opening tag, while other labels like `<FieldLabel>Vite</FieldLabel>` don't. This will render extra whitespace.</violation>
</file>
<file name="apps/ui/registry/default/particles/p-checkbox-group-5.tsx">
<violation number="1" location="apps/ui/registry/default/particles/p-checkbox-group-5.tsx:57">
P2: The submit `Button` is placed inside the `Field` component, which is inconsistent with the existing pattern in `p-radio-group-5.tsx` where the button is correctly placed outside/after the `Field`. The submit button should be a sibling to `Field`, not nested inside it.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
… to align base ui doc
…with descriptions
e350672 to
c07c56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
click the label will not toggle the radio/checkbox in form

After:
click the label will also toggle the radio/checkbox