ING-1366: Fixed Kv Client OnDemandConnect to build clients. #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the OnDemandConnect feature in the KV client pool to properly trigger client connection building. The key issue was that when using OnDemandConnect with a pool, the connection was never actually built because the pool's complex distribution logic bypassed the babysitter's GetClient method that triggers the on-demand build.
Key changes:
- Added validation to ensure OnDemandConnect pools can only have one connection
- Optimized
getClientSlowto directly delegate to the single manager'sGetClientmethod when there's only one manager, which properly triggers on-demand connection building - Removed debug logging statement
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvck
previously approved these changes
Nov 18, 2025
Westwooo
previously approved these changes
Nov 19, 2025
brett19
force-pushed
the
ING-1366_ondemand-connect
branch
from
3a1819c to
8837f08
Compare
thejcfactor
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.