Skip to content

Doc 12754 redux hakim test #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release/8.0
Choose a base branch
from

Conversation

osfameron
Copy link
Collaborator

@osfameron osfameron commented May 29, 2025

@sarahlwelton OK, this was a rather simpler option than what I did yesterday:

  1. First squash all 7 commits together. I did this on the CLI with git rebase -i, but I'm sure that Github Desktop can do this.
    Note that at this point, even though there is only one commit, which ends with the same state as release/8.0, Github shows a file change in modules/search/pages/search-request-params.adoc. That's because of the extra commit on release/8.0 confusing it.
  2. So fetch, and git rebase origin/release/8.0
  3. Force push the PR. Now only 11 files are changed (e.g. not modules/search/pages/search-request-params.adoc)

@osfameron osfameron force-pushed the DOC-12754-redux-hakim-test branch from a3de769 to 8d385c8 Compare May 29, 2025 12:57
@osfameron
Copy link
Collaborator Author

Note that even squashed the modules/search/pages/search-request-params.adoc file has changes, which is odd!

[DOC-12754] Correct search-request-params.adoc

[DOC-12754] Update HEAD.yml for previews

[DOC-12754] Add version/status labels and tweak language

[DOC-12754] Add additional version status labels for clarity

[NO ISSUE] Straightening out lots of merge conflicts and inconsistencies in search-request-params

[DOC-12752] Fix search-request-params pls
@osfameron osfameron force-pushed the DOC-12754-redux-hakim-test branch from 8d385c8 to 47646ac Compare May 29, 2025 13:00
@osfameron osfameron requested a review from sarahlwelton May 29, 2025 13:04
@sarahlwelton
Copy link
Contributor

@sarahlwelton OK, this was a rather simpler option than what I did yesterday:

  1. First squash all 7 commits together. I did this on the CLI with git rebase -i, but I'm sure that Github Desktop can do this.
    Note that at this point, even though there is only one commit, which ends with the same state as release/8.0, Github shows a file change in modules/search/pages/search-request-params.adoc. That's because of the extra commit on release/8.0 confusing it.
  2. So fetch, and git rebase origin/release/8.0
  3. Force push the PR. Now only 11 files are changed (e.g. not modules/search/pages/search-request-params.adoc)

What I ended up doing on my one other branch where rebasing made sense:

  1. Started an interactive rebase to go back to the last good commit I wanted to keep (HEAD~7)
  2. Dropped the commits that tried to correct search-request-params.adoc, picking the others with feature work.
  3. Rebased again onto release/8.0 (git rebase origin/release/8.0)
  4. Force pushed (git push --force-with-lease)

That fixed branch is here: #357

But thanks for doing this to try and show me another method!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants