Fix: Detox is partially configured and is not working #38
Conversation
…orrect the iOS configuration. Remove Hello World test and add "user age consent". Android configuration is still missing.
…ing (the yellow box covers the button to click)
| YellowBox.ignoreWarnings([ | ||
| 'Warning: componentWillReceiveProps has been renamed' | ||
| ]); |
There was a problem hiding this comment.
I had to disable this warning because the yellow box covers the Continue button in the "Your Data" screen of the Onboarding flow, blocking some tests.
There was a problem hiding this comment.
Why not move these to the UNSAFE variants for the time being?
There was a problem hiding this comment.
Thanks @dharding for the comment. I cannot, because that method is used in an imported library, not in the app code. The warning says:
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
...
Please update the following components: Markdown
The src/components/atoms/markdown.tsx does not use that method but the imported M object from react-native-easy-markdown does.
And we are already using the latest version of the library (2.0.0). There isn't an updated version that fixes it.
| // The try/catch block tries to solve an edge case on Android: | ||
| // 1. The emulator is not running. | ||
| // 2. Detox runs the emulator and then the test. | ||
| // 3. Tapping the continue button calls, among other things, the Google SafetyNet Attestation API. | ||
| // 4. The attestation call fails with error code "7". | ||
| // 5. The app remains in Your Data screen and displays an error toast. | ||
| // Note: the attestation call does not fail if the emulator is already running before Detox runs the test. | ||
| // If the app doesn't move to the App Metrics screen, the test taps the continue button again. | ||
| // This time the attestation call should succeed. | ||
| const appMetricsTitle = by.text(en.appUsage.title); | ||
| try { | ||
| // Ensure the app metrics view is displayed. | ||
| await waitForElement(appMetricsTitle, 'toBeVisible', 90); | ||
| } catch (errNotFound) { | ||
| await waitFor(continueButtonEl) | ||
| .toBeVisible() | ||
| .whileElement(scrollViewId) | ||
| .scroll(100, 'down'); | ||
| await continueButtonEl.tap(); | ||
| await waitForElement(appMetricsTitle, 'toBeVisible'); | ||
| } |
There was a problem hiding this comment.
This try/catch block solves an issue happening with the Android emulator.
If the Android emulator is not running before Detox runs the test, some tests fail when the user clicks the Continue button in "Your Data" screen.
This is happening because the button triggers the register call (src/services/api/index.ts), which calls the verify function (src/services/api/index.ts). Here, the Google SafetyNet Attestation call fails with a cryptic [Error: 7: ]. At this point, the app remains in "Your Data" screen and displays a network error toast. The test fails because it expects to find the next screen title ("App Metrics"), but it doesn't.
To detect this error, I had to increase Detox expectation waiting time from 10 to 90 seconds because the attestation call takes about 60 seconds to fail on my machine.
I was not able to find a fix for the Error 7problem, I've checked the react-native-google-safetynet repo, and there is an open issue about this type of error (rajivshah3/react-native-google-safetynet#386). So let's wait to be clarified/fixed by the owner of the library.
I've put in place a workaround to avoid test failing in this particular case: I wait 90 seconds to see if the "App Metrics" title appears; if it doesn't, Detox throws an exception and the app is still in "Your Data" screen. I catch this exception, I click the Continue button and check the existence of the "App Metrics" title again. In my tests, the second Attestation call always works, so the test can continue.
| const appMetricsTitle = by.text(en.appUsage.title); | ||
| // For the explanation of this try/catch block, see the previous test. | ||
| try { | ||
| // Ensure the app metrics view is displayed. | ||
| await waitForElement(appMetricsTitle, 'toBeVisible', 90); | ||
| } catch (errNotFound) { | ||
| await waitFor(continueButtonEl) | ||
| .toBeVisible() | ||
| .whileElement(scrollViewId) | ||
| .scroll(100, 'down'); | ||
| await continueButtonEl.tap(); | ||
| await waitForElement(appMetricsTitle, 'toBeVisible'); | ||
| } |
There was a problem hiding this comment.
See comment above.
This PR closes #37
Please do a
yarn installand then follow the instructions in the README.