Remove deprecated bonding pools #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
Do you know how this impacts some of the vouching queries? With this change we can only reconstruct the current state of vouching, never the historical state.
If you want to remove these entries, I would suggest completely removing the code instead of commenting it out. The query is already complex enough. Having these comments makes it even more difficult to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes bonding pools that are not valid anymore from the relevant dune queries, so as to reduce the possibility of side effects in the accounting pipeline