-
Notifications
You must be signed in to change notification settings - Fork 693
[feat][backend] ob add manual annotation #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 68.02% 68.37% +0.35%
==========================================
Files 568 568
Lines 50484 50742 +258
==========================================
+ Hits 34342 34697 +355
+ Misses 13473 13348 -125
- Partials 2669 2697 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
d74b6ea to
4cfd256
Compare
… DAO implementation Co-Authored-By: Coda <[email protected]>
4cfd256 to
eecaef2
Compare
CozeLoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aime code review: added inline comments for correctness and robustness in spans.go (nil-map assignment; filters nil-guard; annoTable validation) and annotation.go (retry backoff). Please see the inline comments for actionable fixes.
90abce4 to
7058797
Compare
7058797 to
2a5e51f
Compare
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: