Skip to content

Conversation

@kidkidkid
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 80.14184% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckend/modules/observability/infra/repo/ck/spans.go 72.31% 28 Missing and 21 partials ⚠️
.../modules/observability/infra/repo/ck/annotation.go 93.33% 3 Missing and 4 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   68.02%   68.37%   +0.35%     
==========================================
  Files         568      568              
  Lines       50484    50742     +258     
==========================================
+ Hits        34342    34697     +355     
+ Misses      13473    13348     -125     
- Partials     2669     2697      +28     
Flag Coverage Δ
unittests 68.37% <80.14%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../modules/observability/infra/repo/ck/annotation.go 90.17% <93.33%> (+90.17%) ⬆️
...ckend/modules/observability/infra/repo/ck/spans.go 72.70% <72.31%> (+31.01%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a1c70...2a5e51f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch from d74b6ea to 4cfd256 Compare November 5, 2025 06:36
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch from 4cfd256 to eecaef2 Compare November 5, 2025 07:22
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aime code review: added inline comments for correctness and robustness in spans.go (nil-map assignment; filters nil-guard; annoTable validation) and annotation.go (retry backoff). Please see the inline comments for actionable fixes.

@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch 3 times, most recently from 90abce4 to 7058797 Compare November 5, 2025 11:48
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch from 7058797 to 2a5e51f Compare November 5, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants