Skip to content

Conversation

@xueyizheng
Copy link
Collaborator

What type of PR is this?

ExptInsightAnalysisService add start/end time for InsightReport analysis

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@xueyizheng xueyizheng requested a review from CozeLoop November 3, 2025 08:38
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary: Added validation and API design feedback for start/end time propagation in insight analysis, flagged a must-fix for interface change impacting mocks/tests, and marked safe changes. Please see inline comments for actionable guidance.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...evaluation/infra/mq/rocket/consumer/expt_export.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   68.08%   68.09%           
=======================================
  Files         568      568           
  Lines       50548    50557    +9     
=======================================
+ Hits        34418    34425    +7     
- Misses      13459    13460    +1     
- Partials     2671     2672    +1     
Flag Coverage Δ
unittests 68.09% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/modules/evaluation/application/experiment_app.go 77.80% <100.00%> (+0.12%) ⬆️
backend/modules/evaluation/domain/entity/event.go 0.00% <ø> (ø)
...evaluation/domain/service/insight_analysis_impl.go 98.04% <100.00%> (+0.03%) ⬆️
...ackend/modules/evaluation/infra/rpc/agent/agent.go 66.66% <100.00%> (ø)
...evaluation/infra/mq/rocket/consumer/expt_export.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42010f...0031e40. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants