CPANEL-47086 #21
Open
CPANEL-47086 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanel-jared
requested changes
May 29, 2025
There was a problem hiding this comment.
Might have found an issue, there is another call to formataddr() that looks suspect.
This is a different subscription code path that I don't think gets used often, but it contains a formataddr() call that seems like it would fail in the same way as the others.
cpanel-jared
approved these changes
May 29, 2025
…roval. Case CPANEL-47086: A previous fix to decode name into a str before feeding it into formataddr() needed to also be applied to 2 other calls to formataddr(). Changelog: Mailman subscription approval: Fix AttributeError 'bytes' object has no attribute 'encode'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roval.
Case CPANEL-47086: A previous fix to decode name into a str before feeding it into formataddr() needed to apply to a second call to formataddr(), so it has been moved to take effect for both.
Changelog: Mailman subscription approval: Fix AttributeError 'bytes' object
has no attribute 'encode'.