Skip to content

CPANEL-47086 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CPANEL-47086 #21

wants to merge 1 commit into from

Conversation

cpanelrikus
Copy link
Collaborator

…roval.

Case CPANEL-47086: A previous fix to decode name into a str before feeding it into formataddr() needed to apply to a second call to formataddr(), so it has been moved to take effect for both.

Changelog: Mailman subscription approval: Fix AttributeError 'bytes' object
has no attribute 'encode'.

Copy link

@cpanel-jared cpanel-jared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cpanel-jared cpanel-jared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have found an issue, there is another call to formataddr() that looks suspect.

https://github.com/cpanel/mailman2-python3/pull/21/files#diff-a1f9b2b0bea27b1af3e4be3f16fc2d6bf5f77cdbee30144bba0eb69b23fde646L1027

This is a different subscription code path that I don't think gets used often, but it contains a formataddr() call that seems like it would fail in the same way as the others.

…roval.

Case CPANEL-47086: A previous fix to decode name into a str before
feeding it into formataddr() needed to also be applied to 2 other
calls to formataddr().

Changelog: Mailman subscription approval: Fix AttributeError
  'bytes' object has no attribute 'encode'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants