-
Notifications
You must be signed in to change notification settings - Fork 22
docs: update README #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README #308
Conversation
follow-up to #306 Python is no longer required to be installed on the runner anymore. `uv sync` will automatically download the latest supported stable version of Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
WalkthroughAdds markdownlint disables (MD033, MD041) at README top and removes deprecated usage notes (Python 3.10 in Docker, container guidance, link to #185) and a line about creating a GitHub Actions workflow. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
README.md (3)
84-84
: Fix invalid HTML break tagsThe HTML break tag is self-closing and should be
(or
).
is invalid and may render inconsistently.- </br> + <br>Also applies to: 97-97
36-40
: Clarify platform support to avoid contradiction“Only support Linux (Debian-based)” and “MacOS and Windows runners are supported as well” are contradictory as written. Consider rephrasing for clarity, e.g.:
- Primary support: Debian-based Linux (Ubuntu, etc.). macOS and Windows runners are supported on a best-effort basis.
If that’s not accurate, clarify the exact scope of support.
157-157
: Grammar: add an articleMinor wording improvement.
-## Have question or feedback? +## Have a question or feedback?
follow-up to #306
Python is no longer required to be installed on the runner anymore.
uv sync
will automatically download the latest supported stable version of Python.This just removes a note about this in the README.
it also disables a few markdown lint rules that are violated (raw HTML used and first line is not the h1 title).
Summary by CodeRabbit