Fix 1012 #1013
Draft
Fix 1012 #1013
+75
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://1013.mrdocs.prtest2.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://1013.mrdocs.prtest2.cppalliance.org/index.html |
There was a problem hiding this comment.
This is interesting. There are no links or descriptions but I reversed engineered the code and I believe it's a refactor to just pass the whole object and the desired tranche instead of a reference to the trench? This probably conflicts with your other PR where we fix the inheritances where the derived classes overrides it so we could probably wait on this one so we can evaluate the rebased version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.